Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8255615

Zero: demote ZeroStack::abi_stack_available guarantee to assert

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 8, 11, 15, 16
    • Fix Version/s: 16
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b23

      Description

      It is currently guarantee(), which slows down release bits unnecessarily:

      inline int ZeroStack::abi_stack_available(Thread *thread) const {
        guarantee(Thread::current() == thread, "should run in the same thread");

      On my TR 3970X, changing that `guarantee` to `assert` improves:
       - Zero x86_64 release "make images" times from ~9.5 minutes to ~7.5 minutes
       - Zero x86_64 release "make bootcycle-images" times from ~49 minutes to ~44 minutes

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              shade Aleksey Shipilev
              Reporter:
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: