Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8255696

JDWP debug agent's canSuspendResumeThreadLists() should be removed

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 16
    • Fix Version/s: 16
    • Component/s: core-svc
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b23

      Description

      canSuspendResumeThreadLists() is suppose to indicate if JVMTI supports SuspendThreadList. If it doesn't then the agent will call SuspendThread individually on each thread in the list. There are 2 issues with it:

      1. It checks the can_suspend capability, which also indicates if SuspendThread is supported. So if it ever did return false, the agent fallback attempt to use SuspendThread would fail.

      2. The debug agent already requires can_suspend support or it will fail to initialize. See needed_capabilities.can_suspend in debugInit.c.

      canSuspendResumeThreadLists() should be removed as should the code that is executed when it returns false.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              cjplummer Chris Plummer
              Reporter:
              cjplummer Chris Plummer
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: