Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8256205

Simplify compiler calling convention handling

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 16
    • Fix Version/s: 16
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b25

      Description

      Matcher::calling_convention/c_calling_convention simply delegate to SharedRuntime::java_calling_convention/c_calling_convention on all platforms. Since the SPARC removal the is_outgoing argument is also never used, neither in these nor in the return_value methods.

      I think we can refactor this and move some related methods out from the .ad files.

      This might have a tiny positive impact by reducing calls and improving inlining (at least gcc has a hard time inlining anything that goes in the .ad files, even when it's defined to the same class), but is mainly a cleanup effort.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              redestad Claes Redestad
              Reporter:
              redestad Claes Redestad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: