Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8257509

Strengthen requirements to call G1HeapVerifier::verify(VerifyOption)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 16
    • Fix Version/s: 16
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      gc
    • Resolved In Build:
      b28

      Description

      G1HeapVerifier::verify() seems to miss a return:

      void G1HeapVerifier::verify(VerifyOption vo) {
        if (!SafepointSynchronize::is_at_safepoint()) {
          log_info(gc, verify)("Skipping verification. Not at safepoint.");
          // here?
        }
        assert(Thread::current()->is_VM_thread(),
               "Expected to be executed serially by the VM thread at this point");

      Found by [~stefank] during discussion of JDK-8256641.

      This seems to be the case since initial import of that file.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tschatzl Thomas Schatzl
              Reporter:
              tschatzl Thomas Schatzl
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: