Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8257563

Remove excessive include of klass.inline.hpp

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 16
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b28

      Description

      klass.inline.hpp is unnecessarily included by two popular header files:

      https://github.com/openjdk/jdk/blob/fe5cccc1ec76a5c29b1f55af311823f84483395b/src/hotspot/share/oops/oop.inline.hpp#L34

      https://github.com/openjdk/jdk/blob/fe5cccc1ec76a5c29b1f55af311823f84483395b/src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp#L31

      These two lines recursively pull in many header files. Removing them reduced the total number of header inclusion for building HotSpot from 260096 to 254773, or about 2%.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              iklam Ioi Lam
              Reporter:
              iklam Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: