Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8258625

[JVMCI] refactor and unify JVMCI readFieldValue path

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 16, 17
    • Fix Version/s: 17
    • Component/s: hotspot
    • Subcomponent:
    • Resolved In Build:
      b20

      Description

      The JVMCI path to fold constant reads is quite complex because there are multiple paths into it and the introduction of libgraal introduced some more duplication which makes it hard to maintain. It should be simplfied. This cleanup turned out to also a be partial fix for some missing safety checks in the libgraal read folding path, so I'm turning this into a consolidation of those bug fixes. Basically because of code duplication the pure Java paths had bounds checks which the libgraal path was mostly missing. This refactoring ensures that all code goes through the exact same safety check no matter how the path is entered.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              never Tom Rodriguez
              Reporter:
              never Tom Rodriguez
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: