Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8260250

Duplicate check in DebugInformationRecorder::recorders_frozen

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 8, 11, 16, 17
    • Fix Version/s: 17
    • Component/s: hotspot
    • Subcomponent:
    • Resolved In Build:
      b07

      Description

      SonarCloud instance reports the bug here:
        Identical sub-expressions on both sides of operator "||".

      bool DebugInformationRecorder::recorders_frozen() {
        return _oop_recorder->is_complete() || _oop_recorder->is_complete();
      }

      It seems to be this way since JDK-6964458. I don't see why it is this way. I think the intent was to check and freeze these two recorders:

      class OopRecorder : public ResourceObj {
       private:
        ValueRecorder<jobject> _oops;
        ValueRecorder<Metadata*> _metadata;

      ...but they are in OopRecorder already, and so we already get what we want with a single call:

      #ifdef ASSERT
        bool is_complete() {
          assert(_oops.is_complete() == _metadata.is_complete(), "must agree");
          return _oops.is_complete();
        }
      #endif

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              shade Aleksey Shipilev
              Reporter:
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: