Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8261304

Clean up anomalies identified in code review comments

    XMLWordPrintable

    Details

    • Subcomponent:
      2d
    • CPU:
      x86_64
    • OS:
      os_x

      Description

      Lanai code review PR - https://github.com/openjdk/jdk/pull/2403 has identified few minor cleanups-

      1) Remove only white space added to src/java.desktop/share/native/libawt/java2d/SurfaceData.c
      2) src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java - update copyright header to have 2019, 2021
      3) Remove empty spacing added in files -
           - src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformView.java
          - src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java
      4) Correct end of interface description comment in src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.h
      5) Typo in src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.m - "generateion" should be "generation"
      6) src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m -- line 83 - should be jboolean : This code is mixing types; it should be jboolean metalSupported
      7) minor corrections in - src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.h
      8) src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceDataBase.h -- replace reference to openGL with Metal in comment
      9 ) src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTextRenderer.m -- replace reference to openGL drivers

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              aghaisas Ajit Ghaisas
              Reporter:
              aghaisas Ajit Ghaisas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: