Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8261652

Remove some dead comments from os_bsd_x86

    XMLWordPrintable

    Details

    • Subcomponent:
    • Resolved In Build:
      b10
    • CPU:
      x86
    • OS:
      os_x

      Backports

        Description

        This was discovered during review of jep-391
        os_bsd_x86.cpp has comment:

        /*
          NOTE: does not seem to work on bsd.
          if (info == NULL || info->si_code <= 0 || info->si_code == SI_NOINFO) {
            // can't decode this kind of signal
            info = NULL;
          } else {
            assert(sig == info->si_signo, "bad siginfo");
          }
        */

        it was suggested it's better to remove it (in both bsd_x86 and future bsd_aarch64)

        also that file includes pthread.h twice

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                vkempik Vladimir Kempik
                Reporter:
                vkempik Vladimir Kempik
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: