Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8265124

Suspend with handshakes

    XMLWordPrintable

    Details

    • Type: CSR
    • Status: Closed
    • Priority: P4
    • Resolution: Approved
    • Fix Version/s: 17
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Compatibility Kind:
      behavioral
    • Compatibility Risk:
      minimal
    • Compatibility Risk Description:
      Hide
      External suspend request cannot fail with the new mechanism.
      Obsoleting the flags can only generate the new warning messages.
      Show
      External suspend request cannot fail with the new mechanism. Obsoleting the flags can only generate the new warning messages.
    • Interface Kind:
      add/remove/modify command line option

      Description

      Summary

      Obsolete the -XX:SuspendRetryCount and -XX:SuspendRetryDelay flags.

      Problem

      The mechanism for suspending and resuming is being changed. These flags are not used by the new mechanism.

      Solution

      Immediately obsolete the flags in the change-set which changes the suspend/resume mechanism.

      Specification

      The flags will now generate this warning:

      Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option SuspendRetryDelay; support was removed in 17.0

      Full PR: https://github.com/openjdk/jdk/pull/3191

      Commit: https://github.com/openjdk/jdk/pull/3191/commits/5034e8a54467b942186fc7da61ec04a8008b4aa5

      Changes for the flags:

      diff --git a/src/hotspot/share/runtime/arguments.cpp b/src/hotspot/share/runtime/arguments.cpp
      index b17cd9e7ded..fdce017ba73 100644
      --- a/src/hotspot/share/runtime/arguments.cpp
      +++ b/src/hotspot/share/runtime/arguments.cpp
      @@ -523,0 +524,2 @@ static SpecialFlag const special_jvm_flags[] = {
      +  { "SuspendRetryCount",            JDK_Version::undefined(), JDK_Version::jdk(17), JDK_Version::jdk(18) },
      +  { "SuspendRetryDelay",            JDK_Version::undefined(), JDK_Version::jdk(17), JDK_Version::jdk(18) },
      
      diff --git a/src/hotspot/share/runtime/globals.hpp b/src/hotspot/share/runtime/globals.hpp
      index 1c22dc7718c..382dbdaa960 100644
      --- a/src/hotspot/share/runtime/globals.hpp
      +++ b/src/hotspot/share/runtime/globals.hpp
      @@ -429,10 +428,0 @@ const intx ObjectAlignmentInBytes = 8;
      -  /* 50 retries * (5 * current_retry_count) millis = ~6.375 seconds */      \
      -  /* typically, at most a few retries are needed                    */      \
      -  product(intx, SuspendRetryCount, 50,                                      \
      -          "Maximum retry count for an external suspend request")            \
      -          range(0, max_intx)                                                \
      -                                                                            \
      -  product(intx, SuspendRetryDelay, 5,                                       \
      -          "Milliseconds to delay per retry (* current_retry_count)")        \
      -          range(0, max_intx)                                                \
      -                                                                            \

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rehn Robbin Ehn
              Reporter:
              rehn Robbin Ehn
              Reviewed By:
              Daniel Daugherty, David Holmes
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: