Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8265537

x86 version string truncated after JDK-8249672 11u backport

    XMLWordPrintable

    Details

    • Subcomponent:
    • Resolved In Build:
      b01

      Description

      I have been trying to run compiler/intrinsics/sha on 11u, and this happened on TR 3970X (AMD supports SHA on most of their chips, in contrast to Intel):

      $ CONF=linux-x86_64-normal-server-fastdebug make images run-test TEST=compiler/intrinsics/sha/
      TEST: compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java

      TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Option 'UseSHA256Intrinsics' is expected to have 'false' value Option 'UseSHA256Intrinsics' should be disabled by default

      The cause seems to be the JDK-8249672 backport, which effectively enlarged the version string, and resulting string stopped fitting. This is generally innocuous for product code, but the tests line SHA intrinsics tests are going to that version string through Whitebox. At that time, the current 11u test code does not see "sha" feature for the machine in question (thus thinking UseSHA* should be false), while VM code knows that sha is supported (and thus UseSHA* are true). Tests then expectedly fail.

      Mainline and 11u have different buffer sizes. Compare original and backport:
      https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/5c41dc4c48f8#l1.6
      https://hg.openjdk.java.net/jdk/jdk/rev/931c949e05e4#l1.5

      The buffer size was increased with JDK-8238696:
       https://hg.openjdk.java.net/jdk/jdk/rev/a9a78d821f37#l3.20

      ...but that one seems somewhat hard to backport, because it touches a few AVX512 code paths. So, I believe a targeted 11u fix amending the 11u backport is better.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              shade Aleksey Shipilev
              Reporter:
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: