Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8266185

Shenandoah: Fix incorrect comment/assertion messages

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 8-shenandoah, 11.0.9, 16, 17
    • Fix Version/s: 17
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      gc
    • Resolved In Build:
      b21

      Description

      Created on behalf of yude.lyd@alibaba-inc.com
      -------

      I did a grep under src/hotspot/share/gc/shenandoah and found a few places with "G1" keyword:
      $grep -R 'G1'
      c2/shenandoahBarrierSetC2.cpp: assert(sizeof(size_t) == type2aelembytes(index_bt), "Loading G1 SATBMarkQueue::_index with wrong size.");
      c2/shenandoahBarrierSetC2.cpp: // We could be accessing the referent field of a reference object. If so, when G1
      c2/shenandoahBarrierSetC2.cpp: // Verify G1 pre-barriers
      c2/shenandoahBarrierSetC2.cpp: // Pointer stores in G1 barriers looks like unsafe access.
      c2/shenandoahSupport.cpp: assert(sizeof(size_t) == type2aelembytes(index_bt), "Loading G1 SATBMarkQueue::_index with wrong size.");
      shenandoahHeap.cpp: // just as there are G1-specific options.
      shenandoahHeap.cpp: satbqs.set_process_completed_buffers_threshold(20); // G1SATBProcessCompletedThreshold
      shenandoahHeap.cpp: satbqs.set_buffer_enqueue_threshold_percentage(60); // G1SATBBufferEnqueueingThresholdPercent

      I replaced "G1" with "Shenandoah" where I think appropriate.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              shade Aleksey Shipilev
              Reporter:
              yyang Yi Yang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: