Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8267535

Remove the css Selector and ShapeConverter constructors

    XMLWordPrintable

    Details

    • Type: CSR
    • Status: Closed
    • Priority: P4
    • Resolution: Approved
    • Fix Version/s: openjfx17
    • Component/s: javafx
    • Labels:
      None
    • Subcomponent:
    • Compatibility Kind:
      source, binary
    • Compatibility Risk:
      minimal
    • Compatibility Risk Description:
      The constructors were never documented prior to deprecating them for removal, and we expect no applications ever used them.
    • Interface Kind:
      Java API
    • Scope:
      JDK

      Description

      Summary

      Remove the deprecated public constructors javafx.css.Selector and javafx.css.converter.ShapeConverter

      Problem

      • Constructor for class javafx.css.Selector was deprecated for removal in openjfx16. It needs to be removed in openjfx17.
      • Constructor for class javafx.css.converter.ShapeConverter was deprecated for removal in openjfx16. It needs to be removed in openjfx17.

      Solution

      • Constructor for class javafx.css.Selector is made package scoped as it is only extended by classes in the same package.
      • Constructor for class javafx.css.converter.ShapeConverter is made private as it is a singleton class. No javadoc is needed for this simple private constructor.

      Specification

       abstract public class Selector {
      
           /**
      -     * @deprecated This constructor was exposed erroneously and will be removed in the next version. Use {@link #createSelector(String)} instead.
      +     * Package scoped constructor.
            */
      -    @Deprecated(since="16", forRemoval=true)
      -    public Selector() {
      +    Selector() {
           }
      
      
      public class ShapeConverter extends StyleConverter<String, Shape> {
      
      -    /**
      -     * @deprecated This constructor was exposed erroneously and will be removed in the next version. Use {@link #getInstance()} instead.
      -     */
      -    @Deprecated(since="16", forRemoval=true)
      -    public ShapeConverter() {
      +    private ShapeConverter() {
           }

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              aghaisas Ajit Ghaisas
              Reporter:
              kcr Kevin Rushforth
              Reviewed By:
              Kevin Rushforth
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: