Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8268527

[lqagain] langtool tests need tweaks to run properly in an universe where -XDunifiedValRefClass is the default

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: repo-valhalla
    • Fix Version/s: repo-valhalla
    • Component/s: tools
    • Labels:
    • Subcomponent:
    • CPU:
      generic
    • OS:
      generic

      Description

      The following tests fail in the lqagain branch where -XDunifiedValRefClass is the default.

      This is most likely due to the class file disassembly/inspection tests expecting split class files for primitive classes.

      tools/javac/valhalla/lworld-values/ArrayCreationWithQuestion.java: Check array creation with V and V.ref
      tools/javac/valhalla/lworld-values/AttributesTest.java: V.ref class should not inadvertently carry over attributes from V.class
      tools/javac/valhalla/lworld-values/BoxValCastTest.java: Q<->L mixing should be OK for upcasts and should use checkcasts for downcasts.
      tools/javac/valhalla/lworld-values/CheckFieldDescriptors.java: Check field descriptors in class file
      tools/javac/valhalla/lworld-values/CheckNeededCastInMemberAccess.java: Verify that necessary checkcasts are generated while acessing an instance field/method through a reference projection.
      tools/javac/valhalla/lworld-values/InlineNestingAttributesTest.java: Test nest host - member attributes
      tools/javac/valhalla/lworld-values/ProjectedArrayDotClass.java: Javac fails to compile V?[].class (syntax dead)
      tools/javac/valhalla/lworld-values/ProjectionSealed.java: Check to see if the reference projection is a sealed class
      tools/javac/valhalla/lworld-values/RefDotClass.java: Check that we are able to get a class literal for a reference projection type
      tools/javac/valhalla/lworld-values/SignatureTest.java: Incorrect Signature attribute in class file
      tools/javac/valhalla/lworld-values/SplitPrimitiveClassBytecodeTest.java: Experimental support for generating a single class file per primitive class
      tools/javac/valhalla/lworld-values/SplitPrimitiveClassInnerClassesTest.java: Experimental support for generating a single class file per primitive class
      tools/javac/valhalla/lworld-values/SplitPrimitiveClassNestHostTest.java: Experimental support for generating a single class file per primitive class
      tools/javac/valhalla/lworld-values/TopInterfaceTest.java: Introduce and wire-in the new top interfaces
      tools/javac/valhalla/lworld-values/UnannotatedProjection.java: V.ref class should not inadvertently carry over attributes from V.class
      tools/javac/valhalla/lworld-values/UnifiedPrimitiveClassNestHostTest.java: Experimental support for generating a single class file per primitive class

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sadayapalam Srikanth Adayapalam
              Reporter:
              sadayapalam Srikanth Adayapalam
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: