Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8269638

Property methods, setters, and getters in printing API should be final

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: openjfx16
    • Fix Version/s: openjfx18
    • Component/s: javafx
    • Labels:

      Description

      While reviewing JDK-8223717, I discovered that many of methods for the properties in (at least) JobSettings, PageRage, and PrinterJob are not final. In order to maintain the invariant that calling a setting is always the same as calling the set method of the property object, we make all property methods final, specifically, xxxxxProperty(), setXxxxx(), getXxxxx(), and isXxxxx(). Since the classes in question are all final, this isn't a problem in practice, but should be fixed nonetheless (e.g., to avoid copying that pattern to a class that isn't final or in case some day one of the affected classes is made non-final).

      This change will need a CSR.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              prr Philip Race
              Reporter:
              kcr Kevin Rushforth
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: