Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8270842

G1: Only young regions need to redirty outside references in remset.

    XMLWordPrintable

    Details

    • Subcomponent:
      gc
    • Resolved In Build:
      b10

      Description

      For evac failure objects in non-young regions (old) of cset, the outside reference remset already recorded in the dirty queue, we only needs to do it for obj in young regions

      diff --git a/src/hotspot/share/gc/g1/g1EvacFailure.cpp b/src/hotspot/share/gc/g1/g1EvacFailure.cpp
      index 07a4603ade0..1f775badbac 100644
      --- a/src/hotspot/share/gc/g1/g1EvacFailure.cpp
      +++ b/src/hotspot/share/gc/g1/g1EvacFailure.cpp
      @@ -80,6 +80,7 @@ class RemoveSelfForwardPtrObjClosure: public ObjectClosure {
         G1CollectedHeap* _g1h;
         G1ConcurrentMark* _cm;
         HeapRegion* _hr;
      + const bool _is_young;
         size_t _marked_bytes;
         UpdateLogBuffersDeferred* _log_buffer_cl;
         bool _during_concurrent_start;
      @@ -94,6 +95,7 @@ public:
           _g1h(G1CollectedHeap::heap()),
           _cm(_g1h->concurrent_mark()),
           _hr(hr),
      + _is_young(hr->is_young()),
           _marked_bytes(0),
           _log_buffer_cl(log_buffer_cl),
           _during_concurrent_start(during_concurrent_start),
      @@ -152,7 +154,9 @@ public:
             // The problem is that, if evacuation fails, we might have
             // remembered set entries missing given that we skipped cards on
             // the collection set. So, we'll recreate such entries now.
      - obj->oop_iterate(_log_buffer_cl);
      + if (_is_young) {
      + obj->oop_iterate(_log_buffer_cl);
      + }
       
             HeapWord* obj_end = obj_addr + obj_size;
             _last_forwarded_object_end = obj_end;

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mli Hamlin Li
              Reporter:
              mli Hamlin Li
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: