Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8272398

Update DockerTestUtils.buildJdkDockerImage()

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 18
    • Fix Version/s: 18
    • Component/s: hotspot
    • Subcomponent:
    • Resolved In Build:
      b11

      Description

      This work originated while working on "8195809: [TESTBUG] jps and jcmd -l support for containers is not tested".
      The initial intent was to extend the buildJdkDockerImage() API of DockerTestUtils to accept custom Dockerfile content.
      As I analyzed the usage of buildJdkDockerImage() I realized that:
        - 2nd argument "dockerfile" is always the same: "Dockerfile-BasicTest"
            its use has been obsolete for some time, in favor of Dockerfile generated by DockerTestUtils
        - 3rd argument "buildDirName" is also always the same: "jdk-docker"

      Hence I thought it would be a good idea to simplify this API and make it up-to-date.

      Also, since the method signature is being updated, I thought it would be a good idea to also change the name to use more generic container terminology:
      buildJdkDockerImage() --> buildJdkContainerImage()

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mseledtsov Mikhailo Seledtsov
              Reporter:
              mseledtsov Mikhailo Seledtsov
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: