Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8176393 Fix Mutex ranking system
  3. JDK-8272788

Nonleaf ranked locks should not be safepoint_check_never

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 18
    • Fix Version/s: 18
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b14

      Description

      The safepoint_check_never locks should be lower in the lock rank hierarchy and shouldn't be nonleaf. Making them nonleaf implies that other safepoint checking locks can be taken out while they are held, which sort of invites the question of why these locks are safepoint_check_never. If they can't safepoint, why can we safepoint while they're being held?
      I think the ranks were chosen for these locks out of convenience, ie, was just a guess and it worked because other locks taken after these locks were also safepoint_check_never locks.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              coleenp Coleen Phillimore
              Reporter:
              coleenp Coleen Phillimore
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: