Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8277139

Improve code readability in PredecessorValidator (c1_IR.cpp)

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 18
    • Fix Version/s: 18
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b26

      Description

      Refactor PredecessorValidator, more or less applying the following:

      declare variables where used
      redeclare instead of reuse variables
      move assert to a more logical place
      remove unused length variable
      inline variables where senseful
      split loops
      extract methods

      this is done in preparation for work on optimizing IR::verify. IR::verify calls PredecessorValidator. If the work of PredecessorValidator is made clearer, it will be easier to reason about where IR::verify doesn't need to be called (or where a subset of it would suffice).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              lujaniuk Ludvig Janiuk
              Reporter:
              lujaniuk Ludvig Janiuk
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: