Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1026

Skara bot doesn't update Progress checklist for clean backports to show that it is properly reviewed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: bots
    • Labels:
      None

      Description

      The Skara bot checks whether a backport-style pull request is "clean", meaning that the patch for the PR matches the original patch being backported. If it is determined to be clean, the bot adds the "clean" label, and then marks the PR as "ready" for integration, by adding the "ready" label and a comment indicating that the PR can be integrated.

      What it doesn't do is update the checklist in the Progress section of the PR body (Description) to check the box that says "Change must be properly reviewed'. This is confusing and inconsistent, although it seems most people haven't noticed until now. Here are a couple examples:

      https://github.com/openjdk/jfx11u/pull/16
      https://github.com/openjdk/jdk16u/pull/113

      This isn't a high priority issue, but would be nice to fix at some point.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              erikj Erik Joelsson
              Reporter:
              kcr Kevin Rushforth
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: