Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-694

Checking invalid email gives an exception

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9
    • Component/s: bots
    • Labels:
      None

      Description

      Looks like we can end up in a state where an invalid author email is passed to jcheck from a PR.

      [00:08][FINER] issue: author.email is null or empty
      [00:08][FINER] THROWjava.lang.IllegalStateException: Invalid author email: name <>
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.PullRequestCheckIssueVisitor.visit(PullRequestCheckIssueVisitor.java:161)
      at org.openjdk.skara.jcheck/org.openjdk.skara.jcheck.AuthorEmailIssue.accept(AuthorEmailIssue.java:32)
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.CheckablePullRequest.executeChecks(CheckablePullRequest.java:167)
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.CheckRun.checkStatus(CheckRun.java:739)
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.CheckRun.execute(CheckRun.java:88)
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.CheckWorkItem.run(CheckWorkItem.java:186)
      at org.openjdk.skara.bot/org.openjdk.skara.bot.BotRunner$RunnableWorkItem.run(BotRunner.java:79)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ehelin Erik Helin
                Reporter:
                ehelin Erik Helin
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: