Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-876

webrev: sdiff view indentation does not account for width line number

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: cli
    • Labels:
      None

      Description

      The sdiff view of webrev seems to not account for the width of the line numbers. With every additional digit, the code is shifted an additional character to the right.

      This can be seen in the attached sdiff file (from the JDK-8183372, fwiw), at the transition from lines 9->10 and 99->100.

      When reviewing code, this looks like a phantom indentation problem in the code change.

        Attachments

          Activity

            People

            Assignee:
            ehelin Erik Helin
            Reporter:
            bchristi Brent Christian
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: