Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-980

Update log level of thrown exceptions

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Closed
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9
    • Component/s: libraries
    • Labels:
      None

      Description

      Several places in the Skara code uses log.throwing for logging exceptions, for example https://github.com/openjdk/skara/blob/53bfe81aac9524da410607ef9e148fef7bda7e74/bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java#L292 . This unfortunately logs them at the "finest" level, which may end up being filtered when the logs are stored.

      More recent code has switched to using log.log(level, msg, exception) instead to allow setting a reasonable level, like https://github.com/openjdk/skara/blob/53bfe81aac9524da410607ef9e148fef7bda7e74/bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java#L129 . It would be nice to update all the log.throwing calls to use log.log instead.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              erikj Erik Joelsson
              Reporter:
              rwestberg Robin Westberg (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: