Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8073543

Circular include dependency between psScavenge.inline.hpp and psPromotionManager.inline.hpp

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • Resolved In Build:
      b54

      Backports

        Description

        There's a circular dependency between PSScavenge and PSPromotionManager. One example where this can be seen is the call chain:

         PSPromotionManager::process_popped_location_depth(...)
          PSScavenge::copy_and_push_safe_barrier(...)
           PSPromotionManager::copy_to_survivor_space(...)

        These functions are located in the psScavenge.inline.hpp and psPromotionManager.inline.hpp.

        Today there are these include paths:
         psScavenge.inline.hpp -> psPromotionManager.inline.hpp
         psPromotionManager.inline.hpp -> oop.psgc.inline.hpp -> psScavenge.inline.hpp

        I propose that we move PSScavenge::copy_and_push_safe_barrier to the PSPromotionManager class and get rid of the psPromotionManager.inline.hpp -> oop.psgc.inline.hpp -> psScavenge.inline.hpp
        include chain.

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  stefank Stefan Karlsson
                  Reporter:
                  stefank Stefan Karlsson
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: