Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8276983

Small fixes to DumpAllocStat::print_stats

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 18
    • Fix Version/s: 18
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b24

      Description

      When looking at CDS code in the context of Lilliput, I had to spend some time in DumpAllocStat::print(). I noticed two small things which can be fixed independently:

      - the divide-by-zero check at lines 45ff are not needed, since `percent_of` does this already. It also can cause the asserts at the end of the function to fire wrongly.

      - About those asserts, it makes sense to flush the debug message before scope end, otherwise we won't see the debug message if the asserts fire. If they fire, the debug message would be helpful.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stuefe Thomas Stuefe
              Reporter:
              stuefe Thomas Stuefe
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: